feat: Allow displaying group-by columns on LHS of table by pulpdrew · Pull Request #2149 · ClickHouse/ClickStack

pulpdrew · 2026-04-22T18:27:30Z

Summary

This PR adds a new display setting for table charts, allowing the user to show Group-By columns on the left side of the table, before the series columns. The default remains the same (show group by columns on the RHS).

The existing group-by column detection code in DBTableChart has been improved to handle a few more cases than it was before, resulting in fewer numeric group-by columns being affected by the NumberFormat.

Screenshots or video

How to test locally or on Vercel

This can be tested in the preview environment, in a dashboard or chart explorer table.

References

Linear Issue: Closes HDX-4080
Related PRs:

vercel · 2026-04-22T18:27:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 23, 2026 3:38pm

changeset-bot · 2026-04-22T18:27:42Z

🦋 Changeset detected

Latest commit: d01d8a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/common-utils	Patch
@hyperdx/api	Patch
@hyperdx/app	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-22T18:36:00Z

E2E Test Results

✅ All tests passed • 150 passed • 3 skipped • 1151s

Status	Count
✅ Passed	150
❌ Failed	0
⚠️ Flaky	4
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

github-actions · 2026-04-22T19:04:30Z

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

Critical-path files (2):
- packages/api/src/routers/external-api/v2/dashboards.ts
- packages/api/src/routers/external-api/v2/utils/dashboards.ts
Cross-layer change: touches frontend (packages/app) + backend (packages/api) + shared utils (packages/common-utils)

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats

Production files changed: 9
Production lines changed: 102 (+ 437 in test files, excluded from tier calculation)
Branch: drew/display-group-columns-lhs
Author: pulpdrew

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

github-actions · 2026-04-22T19:06:07Z

PR Review

feat: Allow displaying group-by columns on LHS of table — well-structured feature with solid test coverage (unit + E2E). No critical bugs or security issues.

⚠️ Implicit column-order contract — DBTableChart.tsx:303 infers group-by keys by counting from the end of allKeys, relying on ClickHouse always returning series columns before group-by columns. If that query contract ever changes, column detection silently breaks. Consider at minimum a code comment (or assertion in dev) documenting this invariant.
⚠️ configType defaults to undefined, not 'sql' — ChartDisplaySettingsDrawer.tsx:166: showGroupByColumnsOnLeft = displayType === DisplayType.Table && configType !== 'sql'. Any caller that omits configType will show the checkbox for SQL table configs too. The actual reordering is correctly guarded by isBuilderChartConfig() so there's no data bug, but the checkbox would appear and do nothing. Verify all ChartDisplaySettingsDrawer callsites pass configType, or flip the default to require an explicit 'builder' opt-in.
ℹ️ groupByColumnsOnLeft is added to _ChartConfigSchema (the base schema shared by all chart types), not just the table-specific schema. Low risk, but it leaks the field into non-table configs where it has no meaning.

✅ Logic for ratio configs (seriesCount = 1), empty result sets, and raw SQL pass-through are all handled correctly and covered by tests.

pulpdrew · 2026-04-22T19:07:03Z

@@ -109,10 +121,11 @@ export default function ChartDisplaySettingsDrawer({
      <Stack>
        {isTimeChart && (
          <>
-            <Checkbox
+            <CheckBoxControlled


Fix - these checkboxes were not being reset when the reset to defaults button is clicked, since they accept a checked prop instead of the value prop provided by {...register(...)}

pulpdrew · 2026-04-22T19:07:49Z

    ) {
-      groupByKeys = queriedConfig.groupBy.split(',').map(v => v.trim());


This old logic failed when the groupBy contained an alias

) ## Summary Follow-up to #2149. Drew added `groupByColumnsOnLeft` to the external-API table chart config and to the conversion path in #2149, but the MCP `hyperdx_save_dashboard` tool did not advertise the field on its table-tile schema. As a result, MCP clients had no way to discover or set the option, even though the underlying save / fetch plumbing already supports it. This change adds the field to `mcpTableTileSchema.config` and extends the existing multi-tile MCP test to assert a table tile with `groupByColumnsOnLeft: true` round-trips through `hyperdx_save_dashboard`. ## Test plan - [x] `yarn tsc --noEmit` clean in `packages/api` - [x] `yarn lint` clean in `packages/api` - [x] Existing MCP dashboard suite passes; the `should create a dashboard with multiple tile types` row now also asserts `groupByColumnsOnLeft` on the table tile round-trips - [x] External API tests covering `groupByColumnsOnLeft` round-trip still pass (no change to that surface; verified locally)

pulpdrew force-pushed the drew/display-group-columns-lhs branch from 88be6c3 to 38ae330 Compare April 22, 2026 19:03

pulpdrew marked this pull request as ready for review April 22, 2026 19:03

github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 22, 2026

vercel Bot deployed to Preview April 22, 2026 19:06

View deployment

pulpdrew commented Apr 22, 2026

View reviewed changes

feat: Allow displaying group-by columns on LHS of table

1eb9585

pulpdrew force-pushed the drew/display-group-columns-lhs branch from 38ae330 to 1eb9585 Compare April 22, 2026 19:11

vercel Bot deployed to Preview April 22, 2026 19:13

View deployment

pulpdrew requested review from a team and karl-power and removed request for a team April 22, 2026 19:25

karl-power approved these changes Apr 23, 2026

View reviewed changes

pulpdrew added the automerge label Apr 23, 2026

Merge branch 'main' into drew/display-group-columns-lhs

d01d8a2

vercel Bot deployed to Preview April 23, 2026 15:38

View deployment

kodiakhq Bot merged commit 4c23e10 into main Apr 23, 2026
18 checks passed

kodiakhq Bot deleted the drew/display-group-columns-lhs branch April 23, 2026 15:44

alex-fedotyev mentioned this pull request May 5, 2026

feat: add groupByColumnsOnLeft to MCP dashboard table tile schema #2198

Merged

4 tasks done

pulpdrew mentioned this pull request Jun 4, 2026

Number format for tables should not be applied for non-numeric values (grouping keys) #1510

Closed

Navigation Menu

Repository navigation

feat: Allow displaying group-by columns on LHS of table - #2149

feat: Allow displaying group-by columns on LHS of table#2149
kodiakhq[bot] merged 2 commits into
mainfrom
drew/display-group-columns-lhs

pulpdrew commented Apr 22, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

pulpdrew Apr 22, 2026

Uh oh!

pulpdrew Apr 22, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		) {
		groupByKeys = queriedConfig.groupBy.split(',').map(v => v.trim());

Conversation

pulpdrew commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots or video

How to test locally or on Vercel

References

Uh oh!

vercel Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Tier 4 — Critical

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

pulpdrew Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

pulpdrew Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pulpdrew commented Apr 22, 2026 •

edited

Loading

vercel Bot commented Apr 22, 2026 •

edited

Loading

changeset-bot Bot commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading